-
Notifications
You must be signed in to change notification settings - Fork 154
makisu pull: add support for --registry-config #359
base: master
Are you sure you want to change the base?
Conversation
aad9b0f
to
8e8ccd4
Compare
Hi @sema, would you be able to review this feature? Also, it looks like the Fossa check on Travis has been failing for the past couple months, if that's something you can fix.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!
I implemented something similar in #354. It also seemed that deleting the DockerHubRegistry code was needed to allow pulling from docker.io. The rest of makisu only allows configuration with It's a little confusing to leave the hardcoded docker.io config if this registry-config option is added, because it cannot be overridden (I think so at least). |
8e8ccd4
to
470bc53
Compare
@bburky yours is very similar indeed, but with a larger scope than what I'm doing here. You could also rebase your PR on top of |
Build is now failing due to rate limiting on DockerHub. I'll kick it again is a couple hours.
EDIT: build now passes but the Fossa check is still missing an API key... |
This is useful to authenticate with the registry when pulling images.
470bc53
to
7c79732
Compare
This is useful to authenticate with the registry when pulling images.